Skip to content

Conversation

@manisandro
Copy link
Contributor

Patch from the Fedora package

@scottfurry
Copy link
Contributor

The use of named parameters (i.e. 'NAMES' et al) in the calls to find_library is a good thing. Explicit is better than implicit.

I would also point out that this is from Fedora. They have a tendency to name files/packages on their terms ignoring what other distributions might name things. The patch appears to add library names for this reason.

Overall, I don't see conflicts. Merge should be okay.

@mgrojo
Copy link
Member

mgrojo commented Feb 13, 2022

Thanks, @manisandro.

@mgrojo mgrojo merged commit 3c9f218 into sqlitebrowser:master Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants