-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
QTableView int32_t overflow workaround #2801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was implemented as a workaround for #2592 and #2787. There is an issue with QTableView integer overflow (int32_t), when QTableView::defaultRowSize() = 30, maximum number of rows which can be rendered is 0x7fffffff / 30 = 71,582,788. When a huge SQLite table is selected in the BrowserTab, DB4S hangs in an infinite render loop. More info #2592 (comment)
The value is not visible in the Preferences dialog, but can be overwritten from the command line.
|
Thank you very much for this, @sandman7920! I haven't had the chance to review this in detail yet. But two general thoughts from my side:
|
Yes, we could, but if the user resizes only one row, we are in the same position. |
|
Yes, something like that makes sense too. |
d396227 to
16035be
Compare
mgrojo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consider this ready to merge. I'll do it in some days, if there are no objections.
4bc0c36 to
e0a000c
Compare
|
Let's merge this. Nobody objected after more days than I initially thought were going to pass. 😄 Sorry for the long delay. |

Workaround for #2592 and #2787