Skip to content

Conversation

@sandman7920
Copy link
Contributor

There is some strange bug on windows with the system styles (windows and windowsvista).
When styleproxy is used and QDockWidget has a custom stylesheet applied to the widget title, close-button and float-button are rendered huge.

See #2485

Set default maximum icon size for QToolBar to 20px, and for MenuItem to 16px,
before that MenuItem icon was bigger than QToolBar icon.

Pixel metric for SmallIconSize is set to 12px to avoid strange
render behaviour for QDockWidget with custom stylesheet.
…orkaround is applied for windows only.

Screen detection now use QDesktopWidget::screenNumber(const QWidget *widget = nullptr)

toolBarIconSize is set to 18
DB4SProxyStyle is set before any Widget is created.
QGuiApplication::primaryScreen() is used as a screen.
Now custom QPalette can be set before MainWindows is created,
for example exported palette from KDE (Breeze, Breeze Dark, etc).
@mgrojo mgrojo self-requested a review June 15, 2021 21:48
@sandman7920
Copy link
Contributor Author

Screenshot with breeze dark palette imported into DB4s in windows (fusion style).
Looks much more native than a current dark theme.
I will test in macOS to see if it works with macintosh style plugin.

DB4S_dark

mgrojo added a commit that referenced this pull request Jun 18, 2021
Workaround for WindowsVista style (qwindowsvistastyle plugin)

There is some strange bug on windows with the system styles (windows
and windowsvista).  When styleproxy is used and QDockWidget has a
custom stylesheet applied to the widget title, close-button and
float-button are rendered huge.

See #2485
@mgrojo mgrojo merged commit ee6a504 into sqlitebrowser:master Jun 18, 2021
@mgrojo
Copy link
Member

mgrojo commented Jun 18, 2021

I like the new style, nice work! It's now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants