update plotwindow's selection in tablebrowser #2644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a feature that was already present but was broken after 834e650
Member
|
Thanks! This change sounded familiar, and in fact it's the same as 223a7cd @MKleusberg, I haven't investigated it, but I suppose that this line disappeared in one of your optimizations. Would restoring it in this way affect performance? |
Contributor
Author
|
Oh, I bisected till I found that 834e650 was the one that removed this feature. Didn't realize this change was added again in 223a7cd and removed later on for whatever reasons. However, I'd like to emphasize that it's a great feature to have and I have been missing this feature in the recent builds. Even if this is not the optimal way to add this feature, I hope you find a way to add this feature again. Thanks |
8 tasks
Member
|
Let's merge this as commented in #2678. Thanks for taking care of this, @anandsanto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selections made in plot window are presently not shown in the table browser. This is a feature that was present in earlier versions but was broken after 834e650.