Fix issue: save MainWindow geometry, windowState, etc. on exit #2536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MainWindow::closeEvent() now it calls Settings::sync() to call QSettings->sync(). Qt documentation (https://doc.qt.io/qt-5/qsettings.html#sync) says: "This function is called automatically from QSettings's destructor and by the event loop at regular intervals, so you normally don't need to call it yourself." On my Linux machine QSettings was not syncing to the ~/.config/sqlitebrowser/sqlitebrowser.conf (e.g. if I was doing View -> Window Layout -> Simplify Window Layout and then close quickly was not saved). Other settings recently changed before exiting would have been the same. Note that Settings is fully static so this seems to be an easy fix.
Member
|
Without reviewing the code, the concept itself seems like a good idea. 😄 |
Member
|
Thanks, Carles! I've merged it to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MainWindow::closeEvent() now it calls Settings::sync() to call
QSettings->sync(). Qt documentation
(https://doc.qt.io/qt-5/qsettings.html#sync) says:
"This function is called automatically from QSettings's destructor and
by the event loop at regular intervals, so you normally don't need to
call it yourself."
On my Linux machine QSettings was not syncing to the
~/.config/sqlitebrowser/sqlitebrowser.conf (e.g. if I was doing View ->
Window Layout -> Simplify Window Layout and then close quickly was not
saved). Other settings recently changed before exiting would have been
the same.
Note that Settings is fully static so this seems to be an easy fix.