Add QScrollArea in RemoteDock.ui #2514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously RemoteDock was not resizeable too small due to all the widgets (which have minimum size) Now with QScrollArea a vertical scroll bar appears if needed allowing MainWindow too be smaller
Member
|
I've tested the changes and I see now that the problem was specifically with the Current Database tab inside the Remote dock. It is not easy to make it shrink using an alternative approach, as I recommended in #2513 (comment) , because it would require major changes to the layout in this tab. I don't oppose merging this change, but I will add @MKleusberg as reviewer, as he is the author of this latest changes and might have another idea. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously RemoteDock was not resizeable too small due to all the
widgets (which have minimum size)
Now with QScrollArea a vertical scroll bar appears if needed allowing
MainWindow too be smaller