Skip to content

Conversation

@c-boeckler
Copy link
Contributor

Some cosmetics to the command line argument descriptions (make the verb stand at the end), added some missing dashes and shortcut translations.

@lucydodo lucydodo merged commit 48c8de6 into sqlitebrowser:master Oct 9, 2020
@lucydodo
Copy link
Member

lucydodo commented Oct 9, 2020

LGTM! Thanks for contribution 😄

Update: Now cherry-pick to v3.12.x branch. Sorry for delay.

@FriedrichFroebel
Copy link
Contributor

@c-boeckler Did you verify that the changed shortcuts still work? There have been some discussions regarding them in the past, as some of them did not seem to work any more after the translation.

@c-boeckler
Copy link
Contributor Author

I tried to verify that the shortcuts still work, but unfortunately the “nighly” builds for Windows are much older than 24 hours and do not yet contain this patch.
Anyway, I consider it a bug on its own if the translation of a shortcut in the UI prevents it from working.

@justinclift
Copy link
Member

@c-boeckler Arrrgh, looks like something went wrong with the Windows builds. Looking into it now...

@justinclift
Copy link
Member

Looks like it was just a simple firewall problem, now fixed. The IP address here (where the build machine is located) isn't static, and sometimes leads to the firewall on the nightlies server not allowing uploads. Fortunately, it doesn't happen very often. 😉

@justinclift
Copy link
Member

Rebuilding the Win64 binaries now, just in case. They should be online in about 1/2 hour. Win32 and macOS ones will come after that. 😄

@justinclift
Copy link
Member

@c-boeckler The nightly builds are all updated and online now.

@c-boeckler
Copy link
Contributor Author

I veritifed that the three translated shortcuts still work.
Although in the tab "Execute SQL" Ctrl-D inserts a new line instead of toggling the visibility of “Plot”. But this happenes in prior versions as well, so no regressions here.

@c-boeckler c-boeckler deleted the patch-1 branch October 13, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants