@justinclift May I ask for a review because since you participated in that issue? 🤔

Sure. 😄

I can't review the code in a meaningful way (lack of C++ skill these days).

Looking at the text string "Do NOT ask 'Save Project'", that should probably be updated to "Do NOT ask to 'Save Project'".

It would probably be useful to add some kind of tooltip or similar help text as well, to let people know what this is for. Maybe something like "If this is turned on, then changes to the database file won't generate a save confirmation dialog when closing the database. Instead, the changes will be lost, leaving the database unchanged."

Does that help? 😄

@justinclift Cool 😄 , I'm out there right now, so I'll fix it when I get home. And I am still analyzing about the our project code, so I'm worried that it will cause problems that I don't know. Could you recommend another reviewer? 🤔

Sorry if it's rude. It was never intended to be that way.

then changes to the database file won't generate a save confirmation dialog

Not /strictly/ true. I thought this stopped the dialogs that pop up if you create a new 'execute Sql' tab, and not directly related to the database itself...

that should probably be updated to ...

Do the other controls move to the right automatically, or does lucydodo have to move half a billion controls to align them all? 🤣

Sorry if it's rude. It was never intended to be that way.

Er... if what's rude?

Um, I'm not seeing anything related to rudeness here, so I'm not sure what that comment is about. 🤷‍♂️

Reviewer wise, I'd say @mgrojo probably. 😁

@justinclift It may be a silly concern, but I was worried that it might sound rude to ask an existing reviewer to recommend another reviewer. Each person has a different culture, so I'm careful about the small things. 🤔 🤔

@chrisjlocke Oh, You're right. 😄
It only works when user open the database file, not the project file, and modify and close the SQL tab.
Is there any other good expression? or would it better to move the checkbox to the 'SQL' tab rather than 'General' tab?

For now, I change and add like the following:

• Change : Do NOT ask 'Save Project' -> Do NOT ask to 'Save Project' in SQL Editor tabs
• New : If this is turned on, then changes to the SQL editor won't generate a
  save a project confirmation dialog when closing the SQL editor tab. Instead, the changes will be lost.

Here's the screenshot but it's not look neat even to me. I think it needs to be modification.

Do NOT ask to 'Save Project' in SQL Editor tabs

"Do NOT prompt to save SQL tabs in new project file."
Maybe... 😉

Did you squish down the 'Manage' button while you were there? On my system, its huuuuuuuuuuuuuuuuuuuge.... (and looks weird!)

Why not "Prompt to save SQL tabs in new project file" with default value True?

That's a good idea. 😄

Good idea, @mgrojo

@mgrojo Thanks for great idea 😄 I just modified the code according to your review.

Are you saying squash all the commits of this PR?

Are you saying squash all the commits of this PR?

Don't worry about that. That can be done at the end before merging and can be done through the GitHub web controls. What I'm asking is to undo all the unnecessary changes in the PreferencesDialog.ui file. This could be done restoring the original version and inserting the new check-button. I suppose the remaining changes are unneeded and unrelated to this pull-request. Am I wrong about it?

oh, sorry I misunderstood. I have already reverted unnecessary changes to PreferencesDialog.ui
Maybe it looks messy with new checkbox being added between existing items.

Or shall I re-deisgn in Qt Creator and compare?

@mgrojo I'm really sorry. I was wrong. I tried again in Qt Creator and the changes are drastically reduced.
I guess I made a mistake while editing the layout. I just re-committed.

No problem at all! It's now squashed and merged into the master branch.

Thanks to the members who gave me valuable comments and reviews. 😄