Remove the Default property of the fetching dialog #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the default and auto-default properties of the cancel button in the "Fetching data..." dialog. See issue #2383
Member
Author
|
@justinclift Do you mind launching a Windows build so @datvm can test whether #2383 is solved before merging this? |
Member
|
No worries. Win64 build is here. 😄
Can do a Win32 one as well, if that'd be useful |
|
Hi, just tested @justinclift 's zip file, can confirm the mouse cursor no longer moves to the dialog. P.s: probably unrelated but an old message box reappears in this build. I think just because you haven't merged the fix yet but still notify you just in case:
|
Member
Author
|
Thanks @datvm. It's already merged. The message is already fixed in the master branch. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the default and auto-default properties of the cancel button in the
"Fetching data..." dialog.
See issue #2383