Skip to content

Fix cmake build on macOS #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MKleusberg merged 1 commit into from
Jul 21, 2020
Merged

Fix cmake build on macOS #2341

MKleusberg merged 1 commit into from
Jul 21, 2020

Conversation

@sikmir
Copy link
Contributor

@sikmir sikmir commented Jul 21, 2020

Cmake build fails on macOS with:

...
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
CMake Error in CMakeLists.txt:
  No known features for CXX compiler

  "Clang"

  version 5.0.2.


CMake Generate step failed.  Build files cannot be regenerated correctly.

Root cause is the same as https://trac.macports.org/ticket/57700#comment:6 (TLDR: cmake_minimum_required() should be before project()).

@MKleusberg
Copy link
Member

MKleusberg commented Jul 21, 2020

Thanks, @sikmir! 👍

@MKleusberg MKleusberg merged commit 73819f5 into sqlitebrowser:master Jul 21, 2020
@sikmir sikmir deleted the fix-build branch July 21, 2020 11:40
@justinclift justinclift added this to the 3.13.0 - Future release milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sikmir sikmir

Labels

osx

Projects

None yet

Milestone

3.13.0 - Future release

Development

Successfully merging this pull request may close these issues.

3 participants

@sikmir @MKleusberg @justinclift