Skip to content

Conversation

@horst-p-w-neubauer
Copy link
Member

Implements open a set of SQL-Files #2207
Allows to select more than one File in the OpenDialog and opens them in new tabs.

analyze open translations
update German translation

@mgrojo
Copy link
Member

mgrojo commented Apr 26, 2020

Thank you, @horst-p-w-neubauer!

The general feature of opening multiple files is great, though. But I have no time now to make the code review.

But I'm used to my editor of choice (emacs) that can open multiple "buffers" (tabs in our case) of the same underlying file. Is only one tab for file that what we really want? It seems to me arbitrarily limiting the options to the user.

@horst-p-w-neubauer
Copy link
Member Author

Is there anything, I can do?

Copy link
Member

@mgrojo mgrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. It's simple (so no risk and could even enter 3.12, unless we don't want to request retranslations) and very useful.

But all the changes in the translation files are raising conflicts now. Since they are derived from code, unless the commits include a wide fix for all the translation files, it's better to not update them in pull requests. I guess it's better to remake the commit without them than trying to resolve the conflicts.

Implements open a set of SQL-Files sqlitebrowser#2207
Allows to select more than one File in the OpenDialog and opens them in new tabs.

analyze open translations
update German translation
@horst-p-w-neubauer
Copy link
Member Author

dumped al .ts files changes

@mgrojo mgrojo merged commit b0a0e34 into sqlitebrowser:master May 2, 2020
@mgrojo
Copy link
Member

mgrojo commented May 2, 2020

Thanks @horst-p-w-neubauer. It's now merged!

@horst-p-w-neubauer horst-p-w-neubauer deleted the OpenFileSet branch May 2, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants