Skip to content

Conversation

@mgrojo
Copy link
Member

@mgrojo mgrojo commented Apr 4, 2020

Ideally there should be dialogs for editing views and triggers, but with
this feature, users will get a new SQL tab with the necessary statements
to recreate the object, so they can edit it and run it easily.

Ideally there should be dialogs for editing views and triggers, but with
this feature, users will get a new SQL tab with the necessary statements
to recreate the object, so they can edit it and run it easily.
@mgrojo
Copy link
Member Author

mgrojo commented Apr 4, 2020

To be decided if this little feature enters the next release. It would add three new strings to translate.

@justinclift
Copy link
Member

Sounds useful. We might as well include it, as having a few extra strings to translate shouldn't be too much hassle. 😄

@mgrojo
Copy link
Member Author

mgrojo commented May 2, 2020

Since the 3.12.x branch is already open, we can decide later whether this can be picked there or not. Otherwise, I think this is ready for merging to master, so I'm doing it now.

@mgrojo mgrojo merged commit ebeef14 into master May 2, 2020
@mgrojo mgrojo deleted the edit_sql_views_triggers branch May 2, 2020 22:12
@justinclift
Copy link
Member

@mgrojo If you reckon this is safe to cherry-pick across to the 3.12.x branch, lets do it. Same for the other recent PR's too. 😄

@mgrojo
Copy link
Member Author

mgrojo commented May 3, 2020

Yes, but let's wait some time so people can play with the nightlies and report any possible glitch.

@justinclift
Copy link
Member

No worries. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants