-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Italian translation #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Italian translation #1705
Conversation
|
Hi @GortiZ6, it's fine for me, thank you for your help 😄 |
|
Hmmm, this build is failing due to the AppImage stuff (@deepsidhu1313, this might be of interest). @GortiZ6 @Feyn-Man Should this be merged now, or is it still in progress? 😄 |
|
@justinclift: Yes it helps, I'll remember for next time. |
For me it can be merged, all strings have been translated up to master. |
|
Thanks @GortiZ6, just merged it. As a thought, are the strings in the |
|
@justinclift I've tried to merge this ts file on v3.11.x and everything but one translation was automatically imported. To fix that missing one I've made a new TS file for v3.11.x that you can find on my branch: |
|
Hi ,
Sorry for late reply. Is it still failing , due to AppImage code ??
|
|
|
Sorry guys i dont have access to any machine right now. You can comment out
few lines from travis.yml file and i will try to release a fix this
weekend.
Thanks !!
|
|
@GortiZ6 Thanks, I'll have a go at merging your branch now. 😄 @deepsidhu1313 No worries. I've just nuked the AppImage lines from the .travis config. Feel free to add them back / experiment / etc when you have some time and feel up for it. 😄 |
|
@GortiZ6 That turned out to be pretty easy. I just cherry-picked the two commits from your |
|
Tracking down a failure in our Windows builds... it turns out to be caused by this. Oops. 😉 Looks like the translation file was renamed to upper case for one part of it's name, with a soft link pointing to the new name. Do you remember what that was for? We'll need to change the name back to get things working, but it'd be useful to know the problem that the rename was meant to solve, just in case it's important for something else. 😄 |
|
Actually it was just to match the "it_IT" language code and leave space for an "it_CH" translation without eliminating the previous generic "it" definition... I forgot the Windows build and issues with the softlink, it was just to avoid to have two equal files for the translations and to maintain them both. For me it's ok also to keep only the generic "it" translation and to push this issue forward in case some one arise the need to have an it_CH translation (which I found quite improbable). |
|
Ahhh. If we do need to rename the file around (eg to I think (without testing it), that should work. 😄 |
Completed and fixed italian translation started by @Feyn-Man.
I'd like to ask him if it's ok to use this new version or if he prefers to change something else, but I don't know how to contact him, I hope he reads this merge request :)