Source trigger patch file drop #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send Signal and return if Index is invalid and File was dropped
14 tasks
Member
|
Thanks for doing this @SourceTrigger! Hopefully @MKleusberg or @mgrojo have time to review this in the next day or two. 😄 |
Member
|
Thanks a lot, @SourceTrigger, looks good 👍 |
SourceTrigger
added a commit
to SourceTrigger/sqlitebrowser
that referenced
this pull request
Nov 20, 2017
Source trigger patch file drop (sqlitebrowser#1236)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that the application crashes when dragging a file to a non-valid index in the table. At the same time the file will be opened in this case.
I add a Signal/Slot to communicate with ExtendTableWidget and MainWindow and validate Index after drop anything.