Fixed crash when editing the display format while the currently browsed table name is actually a view #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cell as filter in this column. This allows quick filtering by selected values.
…get internal cell data and check for the NULL special case.
Reviewed translation following guidelines the KDE Spanish Translation Team: https://es.l10n.kde.org/ Warnings raised by linguist have been solved.
…ed table name is actually a view. Now it is checked the object type before the cast. This avoids the crash and the field name is obtained for each case.
Member
|
Thanks, @mgrojo! Awesome, that's a good catch 😄 It also shows that I need to finally clean up all the code in sqlitetypes.cpp one day to avoid such bugs in the future... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is checked the object type before the cast. This avoids the crash and then the field name is obtained depending on each case.