Repository navigation
docs: remove outdated Snowflake USING note from Rule ST07 - #8715
Merged
keraion merged 3 commits intoOct 14, 2026
Merged
Conversation
Snowflake confirmed the USING inconsistencies no longer exist, so the note claiming otherwise is outdated. Keeps the dbt style guide history. Closes sqlfluff#4068 Signed-off-by: Shahzeb Ali <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
The URL had a stray space causing docutils to reject the RST link. Signed-off-by: Shahzeb Ali <[email protected]>
keraion
reviewed
Oct 14, 2026
|
|
||
| Certain warehouses have inconsistencies in ``USING`` | ||
| results (specifically Snowflake). | ||
| <https://github.com/dbt-labs/corp/blob/main/dbt_style_guide.md>`_. |
Contributor
There was a problem hiding this comment.
Unfortunately, this link (and the PR link below) is now dead. I think it's fine to leave the context, but drop the links now.
Contributor
Author
There was a problem hiding this comment.
Good catch, both links are 404s. Dropped the links and kept the historical context in 11f28ee. Thanks!
The dbt style guide and the PR removing the rule from it are both gone (404), so keep the historical context without the links. Addresses review feedback on sqlfluff#8715.
Contributor
Coverage Results ✅ |
keraion
approved these changes
Oct 14, 2026
keraion
left a comment
keraion
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the clean up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the outdated note claiming Snowflake has inconsistencies in
USINGresults. Snowflake confirmed these inconsistencies no longer exist (see issue). Keeps the dbt style guide history for context.Closes #4068
Summary by cubic
Removes the outdated Snowflake
USINGinconsistency note from Rule ST07 and drops the now-dead dbt style guide links from the note. Snowflake confirmed the inconsistencies no longer exist, and the dbt style guide and the PR that removed the rule from it are both gone (404), so the note keeps only the historical context. Also fixes a stray space in the dbt style guide URL that broke the RST link.Closes #4068.
Written for commit 11f28ee. Summary will update on new commits.