Skip to content

Fix rule failures for MySQL/MariaDB with backticked identifiers#6702

Merged
keraion merged 2 commits intosqlfluff:mainfrom
pprkut:mariadb_backtick
Mar 29, 2025
Merged

Fix rule failures for MySQL/MariaDB with backticked identifiers#6702
keraion merged 2 commits intosqlfluff:mainfrom
pprkut:mariadb_backtick

Conversation

@pprkut
Copy link
Copy Markdown
Contributor

@pprkut pprkut commented Mar 3, 2025

Brief summary of the change made

Fixes #5356

Are there any other side effects of this change that we should be aware of?

Not that I can see.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2025

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19336      0   100%

248 files skipped due to complete coverage.

@pprkut pprkut force-pushed the mariadb_backtick branch from ddb7613 to 1891900 Compare March 3, 2025 08:56
Comment thread src/sqlfluff/dialects/dialect_ansi.py Outdated
Comment thread src/sqlfluff/rules/structure/ST11.py Outdated
@pprkut pprkut force-pushed the mariadb_backtick branch from 1891900 to 1d9a691 Compare March 29, 2025 12:48
@pprkut pprkut force-pushed the mariadb_backtick branch from 1d9a691 to 3969059 Compare March 29, 2025 12:57
Copy link
Copy Markdown
Contributor

@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM

@keraion keraion added this pull request to the merge queue Mar 29, 2025
Merged via the queue into sqlfluff:main with commit 0108396 Mar 29, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linting error when using aliases in backticks

2 participants