Skip to content

BigQuery: Support CREATE SNAPSHOT TABLE statement#5779

Merged
WittierDinosaur merged 1 commit intosqlfluff:mainfrom
kzosabe:bigquery-create-snapshot
Apr 18, 2024
Merged

BigQuery: Support CREATE SNAPSHOT TABLE statement#5779
WittierDinosaur merged 1 commit intosqlfluff:mainfrom
kzosabe:bigquery-create-snapshot

Conversation

@kzosabe
Copy link
Copy Markdown
Contributor

@kzosabe kzosabe commented Apr 18, 2024

Brief summary of the change made

fixes #5778

Currently, sqlfluff does not support BigQuery's CREATE SNAPSHOT TABLE statement.
In this PR, we try to implement that.

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2024

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17551      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 18, 2024

Coverage Status

coverage: 99.985%. remained the same
when pulling c20a7d0 on kzosabe:bigquery-create-snapshot
into bd07b60 on sqlfluff:main.

WittierDinosaur
WittierDinosaur approved these changes Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Apr 18, 2024
Merged via the queue into sqlfluff:main with commit 1f651ef Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: Support CREATE SNAPSHOT TABLE statement

3 participants

@kzosabe @coveralls @WittierDinosaur