Skip to content

TSQL: allow 'OR ALTER' on 'CREATE TRIGGER'#5772

Merged
WittierDinosaur merged 1 commit intosqlfluff:mainfrom
mhoogendoorn:tsql-create-alter-trigger
Apr 13, 2024
Merged

TSQL: allow 'OR ALTER' on 'CREATE TRIGGER'#5772
WittierDinosaur merged 1 commit intosqlfluff:mainfrom
mhoogendoorn:tsql-create-alter-trigger

Conversation

@mhoogendoorn
Copy link
Copy Markdown
Contributor

Brief summary of the change made

Allow the optional OR ALTER on CREATE TRIGGER statements in T-SQL dialect. This is already possible on VIEW, FUNCTION and PROCEDURE.

Are there any other side effects of this change that we should be aware of?

Not as far as I know.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).

Copy link
Copy Markdown
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Apr 13, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17539      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 99.985%. remained the same
when pulling 1a98a21 on mhoogendoorn:tsql-create-alter-trigger
into 4722f99 on sqlfluff:main.

Merged via the queue into sqlfluff:main with commit 26630ce Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants