Skip to content

TSQL: Fix bare functions in default constraints#5771

Merged
alanmcruickshank merged 1 commit intosqlfluff:mainfrom
MarkPaulin:main
Apr 13, 2024
Merged

TSQL: Fix bare functions in default constraints#5771
alanmcruickshank merged 1 commit intosqlfluff:mainfrom
MarkPaulin:main

Conversation

@MarkPaulin
Copy link
Copy Markdown
Contributor

Brief summary of the change made

Adds support for bare functions in column default constraints for TSQL.
Fixes #4631

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).

Copy link
Copy Markdown
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17457      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 99.984%. remained the same
when pulling bb9f7e8 on MarkPaulin:main
into cda058e on sqlfluff:main.

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Apr 13, 2024
Merged via the queue into sqlfluff:main with commit cbddd6d Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to use CURRENT_TIMESTAMP keyword as DEFAULT value (TSQL)

4 participants