Skip to content

MySQL: Fix parsing 'ALTER TABLE ts ADD COLUMN modified_at TIMESTAMP NULL DEFAULT NULL ON UPDATE CURRENT_TIMESTAMP;' (#5766)#5767

Merged
WittierDinosaur merged 1 commit intosqlfluff:mainfrom
olshak:main
Apr 13, 2024
Merged

Conversation

@olshak
Copy link
Copy Markdown
Contributor

@olshak olshak commented Apr 10, 2024

Brief summary of the change made

fixes #5766

Are there any other side effects of this change that we should be aware of?

The fix is for a special TIMESTAMP logic within column definition, so I don't think so.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@olshak olshak mentioned this pull request Apr 10, 2024
Closed
3 tasks
@olshak olshak changed the title MySQL: Fix parsing 'ALTER TABLE tsADD COLUMNmodified_at timestamp NULL DEFAULT NULL ON UPDATE CURRENT_TIMESTAMP;' (#5766) MySQL: Fix parsing 'ALTER TABLE ts ADD COLUMN modified_at TIMESTAMP NULL DEFAULT NULL ON UPDATE CURRENT_TIMESTAMP;' (#5766) Apr 10, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 12, 2024

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17457      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 12, 2024

Coverage Status

coverage: 99.984%. remained the same
when pulling f0770d1 on olshak:main
into cda058e on sqlfluff:main.

WittierDinosaur
WittierDinosaur approved these changes Apr 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Apr 13, 2024
Merged via the queue into sqlfluff:main with commit 422a92b Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Alter statement is not parsable

3 participants

@olshak @coveralls @WittierDinosaur