Skip to content

ST04: Retain comments when flattening CASE#5753

Merged
WittierDinosaur merged 3 commits intosqlfluff:mainfrom
keraion:ST04_retain_comments
Apr 7, 2024
Merged

ST04: Retain comments when flattening CASE#5753
WittierDinosaur merged 3 commits intosqlfluff:mainfrom
keraion:ST04_retain_comments

Conversation

@keraion
Copy link
Copy Markdown
Contributor

@keraion keraion commented Apr 7, 2024

Brief summary of the change made

Fix to retain comments when flattening nested case statements.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17441      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 7, 2024 •
edited
Loading

Coverage Status

coverage: 99.984%. remained the same
when pulling 5d37726 on keraion:ST04_retain_comments
into 081a526 on sqlfluff:main.

WittierDinosaur
WittierDinosaur reviewed Apr 7, 2024
View reviewed changes
Comment thread src/sqlfluff/rules/structure/ST04.py Outdated
WittierDinosaur
WittierDinosaur approved these changes Apr 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Apr 7, 2024
Merged via the queue into sqlfluff:main with commit 032ce0f Apr 7, 2024
@keraion keraion deleted the ST04_retain_comments branch April 8, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue: SQLFluff removes comments inside a nested CASE statement ST04: Flattening of CASE ... WHEN statements removes comments

3 participants

@keraion @coveralls @WittierDinosaur