Change Color.lightgrey to have a white background - dark theme friendly#5458
Merged
greg-finley merged 1 commit intosqlfluff:mainfrom Dec 10, 2023
Merged
Change Color.lightgrey to have a white background - dark theme friendly#5458greg-finley merged 1 commit intosqlfluff:mainfrom
greg-finley merged 1 commit intosqlfluff:mainfrom
Conversation
To allow a better experience for dark-background users, adding a background of WHITE seems to be a good experience. Tested on about 10 themes in MacOS' Terminal.app and alacritty for both dark and light backgrounds.
Contributor
Coverage Results ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
To allow a better experience for dark-background users, adding a background of WHITE seems to be a good experience.
Tested on about 10 themes in MacOS' Terminal.app and alacritty for both dark and light backgrounds.
Related to #1170
Explored replacing the output formatter with
rich, but that seems like too much work when I think this simple fix will do.Are there any other side effects of this change that we should be aware of?
No known side effects
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.