Repository navigation
Add support for ANY_VALUE( _ HAVING MIN/MAX _ ) to BigQuery dialect - #5321
Merged
alanmcruickshank merged 1 commit intoOct 16, 2023
Conversation
ebonnal
force-pushed
the
bonnal-enzo/add_having_min_max_to_bigquery_dialect
branch
from
October 14, 2023 00:46
573c7b1 to
41d9807
Compare
ebonnal
marked this pull request as ready for review
October 14, 2023 00:49
ebonnal
changed the title
alanmcruickshank
approved these changes
Oct 16, 2023
alanmcruickshank
left a comment
alanmcruickshank
left a comment
Member
There was a problem hiding this comment.
Looks really clear. The test suite hasn't run yet, but assuming no issues there, this looks great! 👍 Thanks for contributing.
alanmcruickshank
enabled auto-merge
October 16, 2023 11:16
Contributor
Coverage Results ✅ |
ebonnal
changed the title
ANY_VALUE( _ HAVING MIN/MAX _ ) to BigQuery dialect
rubytobi
pushed a commit
to tobycraft/sqlfluff
that referenced
this pull request
Jun 16, 2026
benfdking
pushed a commit
to quarylabs/sqruff
that referenced
this pull request
Aug 29, 2026
…321) ## Summary - Advance `.sqlfluff-sha` to 7dcee95f045a671a85e5246da380b9517ffdb4a1. - SQLFluff #5321 adds BigQuery support for `ANY_VALUE( _ HAVING MIN/MAX _ )`. The grammar (`FunctionContentsExpressionGrammar`), the `MIN`/`MAX` keywords, and the `any_value_having` parse fixtures are already present in sqruff, so only the SHA needed to advance. Ported from SQLFluff 7dcee95f045a671a85e5246da380b9517ffdb4a1 sqlfluff/sqlfluff#5321 sqlfluff/sqlfluff@7dcee95
benfdking
added a commit
to quarylabs/sqruff
that referenced
this pull request
Aug 29, 2026
…321) (#3372) ## Summary - Advance `.sqlfluff-sha` to 7dcee95f045a671a85e5246da380b9517ffdb4a1. - SQLFluff #5321 adds BigQuery support for `ANY_VALUE( _ HAVING MIN/MAX _ )`. The grammar (`FunctionContentsExpressionGrammar`), the `MIN`/`MAX` keywords, and the `any_value_having` parse fixtures are already present in sqruff, so only the SHA needed to advance. Ported from SQLFluff 7dcee95f045a671a85e5246da380b9517ffdb4a1 sqlfluff/sqlfluff#5321 sqlfluff/sqlfluff@7dcee95 Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
These changes make the BigQuery dialect support the
HAVING MINandHAVING MAXfunction contents, allowed inside theANY_VALUEaggregate function.FunctionContentsExpressionGrammarnode.MINandMAXintobigquery_unreserved_keywordsAre there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.