BigQuery: Fix parsing parameterized data types#3735
Merged
barrywhart merged 6 commits intosqlfluff:mainfrom Aug 14, 2022
Merged
BigQuery: Fix parsing parameterized data types#3735barrywhart merged 6 commits intosqlfluff:mainfrom
barrywhart merged 6 commits intosqlfluff:mainfrom
Conversation
yoichi
force-pushed
the
bq-parameterized-data-types
branch
from
5e0b941 to
e5ac55e
Compare
barrywhart
reviewed
Aug 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #3735 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 176 176
Lines 13466 13466
=========================================
Hits 13466 13466
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yoichi
commented
Aug 12, 2022
| Bracketed( | ||
| Sequence( | ||
| Ref("DatatypeSegment"), | ||
| Bracketed(Anything(), optional=True), # For types like STRING(10) |
Contributor
Author
There was a problem hiding this comment.
Finally deleted the comment. STRING(10) is no longer a good example, as I made it Delimited because I needed to support the NUMERIC(5, 2) format. On the other hand, setting the example to NUMERIC(5, 2) is misleading in relation to "Numeric"LiteralSegment.
barrywhart
requested changes
Aug 12, 2022
barrywhart
approved these changes
Aug 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Support parameterized data types (https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types?hl=en#parameterized_data_types)
Fixes #3663
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.