Allow type keywords as unquoted index column names#1104
Merged
gfx merged 1 commit intosqldef:masterfrom Jan 8, 2026
Merged
Conversation
PostgreSQL's pg_get_constraintdef() returns column names like `uuid` without quotes. The generic parser was failing to parse these because type keywords (uuid, int, bigint, json, etc.) defined in type_func_name_keyword were not recognized as valid column names in index definitions. Add type_func_name_keyword as an alternative in the index_column rule for basic, COLLATE, and operator_class patterns. This allows statements like `UNIQUE (uuid)` to parse successfully without requiring quotes. Signed-off-by: moznion <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Contributor
|
Yeah, keywords tend to cause similar issues everywhere, every time. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL's
pg_get_constraintdef()returns column names likeuuidwithout quotes. The generic parser was failing to parse these because type keywords (uuid, int, bigint, json, etc.) defined in type_func_name_keyword were not recognized as valid column names in index definitions.Add type_func_name_keyword as an alternative in the index_column rule for basic, COLLATE, and operator_class patterns. This allows statements like
UNIQUE (uuid)to parse successfully without requiring quotes.