Skip to content

Comments

Tweak --password-prompt behavior#1102

Merged
gfx merged 1 commit intosqldef:masterfrom
moznion:tweak_password-prompt_behavior
Jan 8, 2026
Merged

Tweak --password-prompt behavior#1102
gfx merged 1 commit intosqldef:masterfrom
moznion:tweak_password-prompt_behavior

Conversation

@moznion
Copy link
Contributor

@moznion moznion commented Jan 8, 2026

The Enter Password: prompt message was being written to the output file when output was redirected during export. This patch fixes the issue by sending the prompt message to STDERR instead.
Additionally, it appends a newline character after the password input is completed, making it clear whether the password has been accepted.

The `Enter Password:` prompt message was being written to the output file
when output was redirected during export. This patch fixes the issue by
sending the prompt message to STDERR instead.
Additionally, it appends a newline character after the password input is
completed, making it clear whether the password has been accepted.

Signed-off-by: moznion <[email protected]>
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/mssqldef/mssqldef.go 0.00% 2 Missing ⚠️
cmd/mysqldef/mysqldef.go 0.00% 2 Missing ⚠️
cmd/psqldef/psqldef.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
cmd/mssqldef/mssqldef.go 0.00% <0.00%> (ø)
cmd/mysqldef/mysqldef.go 0.00% <0.00%> (ø)
cmd/psqldef/psqldef.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gfx gfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@gfx gfx added this pull request to the merge queue Jan 8, 2026
Merged via the queue into sqldef:master with commit a14bf94 Jan 8, 2026
24 of 25 checks passed
@sqldef-bot sqldef-bot bot mentioned this pull request Jan 8, 2026
@moznion moznion deleted the tweak_password-prompt_behavior branch January 8, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants