Repository navigation
enable go_struct_tag on column types - #3287
Closed
emanuelturis wants to merge 3 commits into
Closed
emanuelturis wants to merge 3 commits into
emanuelturis wants to merge 3 commits into
Conversation
This was referenced Aug 28, 2024
Collaborator
|
🤖 Automated message This PR has been closed because it has merge conflicts with Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
So, first, this is my first contribution on open source, which means the quality of the pull request isn't the greatest, but I hope at least it leads to the right solution.
I noticed that when specifying the go_struct_tags on overrides, it would only work with column and not db_type.
I found something which to me seems like a workaround, but it now works on my end.
I ran the tests and it seems to all be passing just fine (5 failing tests before the change and after, so no difference there).
I'm looking forward to some feedback and see if this can be merged into the project.
Thanks to everyone!