Skip to content

MySQL: Proper type for YEAR and TINYINT #3201

Closed

Description

@Necoro

Version

1.25.0

What happened?

In issue #3088, SMALLINT was (correctly) changed from int32 to int16.
Surprisingly, TINYINT, which should have int8, has not been touched, resulting in the situation that TINYINT is now larger than SMALLINT.

Additionally, YEAR is checked for signed vs unsigned, even though this flag is not possible for MySQL: it should always result in an uint16.

FWIW: Closing this issue will also close #1856

Relevant log output

No response

Database schema

No response

SQL queries

No response

Configuration

No response

Playground URL

No response

What operating system are you using?

Linux

What database engines are you using?

MySQL

What type of code are you generating?

Go

Activity

  1. added
    bugSomething isn't working
    triageNew issues that hasn't been reviewed
    on Feb 14, 2024
  2. added this to the 1.26.0 milestone on Feb 15, 2024
  3. removed
    triageNew issues that hasn't been reviewed
    on Feb 15, 2024
  4. kyleconroy commented on Feb 16, 2024

    @kyleconroy
    Collaborator

    @Necoro this is a good catch. We'll make sure to make this change before we release 1.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions