Repository navigation
sqlc.slice(): Generate code with unused imports #3065
Description
Version
1.24.0
What happened?
The code imports the unused "strings" package.
Relevant log output
// Code generated by sqlc. DO NOT EDIT.
// versions:
// sqlc v1.24.0
// source: query.sql
package tutorial
import (
"context"
"strings"
)
const getAuthor = `-- name: GetAuthor :one
SELECT id, name, bio FROM authors
WHERE id = any($1)
`
func (q *Queries) GetAuthor(ctx context.Context, idList []int64) (Author, error) {
row := q.db.QueryRow(ctx, getAuthor, idList)
var i Author
err := row.Scan(&i.ID, &i.Name, &i.Bio)
return i, err
}Database schema
CREATE TABLE authors (
id BIGSERIAL PRIMARY KEY,
name text NOT NULL,
bio text
);SQL queries
-- name: GetAuthor :one
SELECT * FROM authors
WHERE id = any(sqlc.slice('id_list'));Configuration
version: "2"
sql:
- engine: "postgresql"
queries: "query.sql"
schema: "schema.sql"
gen:
go:
package: "tutorial"
out: "tutorial"
sql_package: "pgx/v5"Playground URL
What operating system are you using?
Linux
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go
Activity
fix(codegen/golang): Don't import `"strings"` for `sqlc.slice()` with…
fix(codegen/golang): Don't import `"strings"` for `sqlc.slice()` with…
Jille commentedon Dec 21, 2023
I think you might be better off using:
SELECT * FROM authors WHERE id = any(sqlc.arg('id_list')::integer[]);This side-steps the bug and is probably better for statement caching done by the client.
fix(codegen/golang): Don't import `"strings"` for `sqlc.slice()` with…