Go Param Names in Complex Statements #189

Activity

1. kyleconroy

   added

   bugSomething isn't workingSomething isn't working

   on Dec 17, 2019
2. kyleconroy commented on Dec 17, 2019

   

   kyleconroy

   on Dec 17, 2019

   Last edited by kyleconroy

   Collaborator

   More actions

   The naming here isn't very helpful.

   Agreed. It also appears there's something strange going on with the names. There's not reason the second parameter should be Column2_2, it should just be Column2. That said, even the "correct" names are unhelpful.

   Do you have any suggestions on how this can be improved?

   I think I do. We already do inference of parameter names. It's how the query UPDATE foo SET bar = $1 gives you a parameter named Bar, not Column_1. It should be possible to recognize the pattern you're using and generate a struct that looks like this:

   type UpdateFooParams struct {
   	SetBar bool      `json:"set_bar"`
   	Bar    bar_type  `json:"bar"`
   }
   

   Would that be good enough for your needs?

   by somehow annotating things such that the params struct uses more helpful naming?

   We've talked about overriding parameters names in #71
3. kyleconroy

   added

   enhancementNew feature or requestNew feature or request

   on Dec 17, 2019
4. joshuarubin commented on Dec 17, 2019

   

   joshuarubin

   on Dec 17, 2019

   ContributorAuthor

   More actions

   It should be possible to recognize the pattern you're using and generate a struct that looks like this

   Yeah, that's exactly what I'd like. That can be done already?
5. kyleconroy commented on Dec 17, 2019

   

   kyleconroy

   on Dec 17, 2019

   Collaborator

   More actions

   I wish because then I wouldn't have to write it! Sadly it needs to be implemented. In the meantime, you're stuck with terrible parameter names :(
6. kyleconroy

   closed this as completedin #328on Feb 10, 2020
7. kyleconroy commented on Feb 10, 2020

   

   kyleconroy

   on Feb 10, 2020

   Last edited by kyleconroy

   Collaborator

   More actions

   @joshuarubin I just landed support for named parameters. Your original query can be rewritten like so:

   -- name: UpdateFoo :one
   UPDATE foo
   SET
     bar = CASE WHEN sqlc.arg(set_bar)::bool
       THEN sqlc.arg(bar)::bar_type
       ELSE bar
       END
   RETURNING *;

   You can also use the @ shorthand:

   -- name: UpdateFoo :one
   UPDATE foo
   SET
     bar = CASE WHEN @set_bar::bool
       THEN @bar::bar_type
       ELSE bar
       END
   RETURNING *;