Repository navigation
PR: Add PySide2 support - #84
Conversation
|
@dgovil this is great thanks a lot :-) |
Nodd
left a comment
Nodd
left a comment
There was a problem hiding this comment.
A few style comments, mostly...
| os.environ.setdefault(QT_API, 'pyqt5') | ||
| API = os.environ[QT_API].lower() | ||
| assert API in (PYQT5_API + PYQT4_API + PYSIDE_API) | ||
| assert API in (PYQT5_API + PYQT4_API + PYSIDE_API+PYSIDE2_API) |
There was a problem hiding this comment.
Spaces around the + operator please !
| from PySide2.QtWebKitWidgets import QWebView as QWebEngineView | ||
| #: Current PySide2 builds seem to be missing this. | ||
| #: I'll leave it in for now because the final builds should have it | ||
| from PySide2.QtWebKit import QWebSettings as QWebEngineSettings |
There was a problem hiding this comment.
It means that right now importing QtWebEngineWidgets will fail with pyside2 even if QWebEngineSettings is not used ? I'm in favor of commenting this line for now and readding it when pyside2 includes QWebSettings.
|
@Nodd Addressed the notes. Added a newline to the gitignore but for some reason it doesn't seem to survive a push to github. Git status locally shows it's up to date so not sure what's up. Had to add a comment as the last line for it to show up on github, so hopefully that's alright with you. |
|
@dgovil do you have any updates on pyside2 status? |
|
@goanpeca Hi sorry, no I am not aware of what the PySide2 status is as a project. Kind of hard to track when they shifted it off of github. It ships with commercial products right now in its current state however |
|
One can use Qt.py instead, which supports PySide2 (in fact PySide2 is main binding for Qt.py). |
|
@xmikos Yup, I actively use Just put this pull request in to try and get parity between the projects. |
|
This is a blocking issue for matplotlib moving to use qtpy over our own shims. |
|
@tacaswell, really great to know you're considering We just need to add tests for this, that's why we haven't merged it yet. I'll work on that during Easter days :-) |
6081b5a to
b6f584e
Compare
|
Ok, after a lot of work to run our tests with PySide2, this is finally ready!! Thanks @dgovil for your contribution!! |
|
Awesome! Thanks for setting up the tests and test environment. Glad I could contribute. Cheers |
|
Don't forget to update the README to include PySide2! |
|
You're right. We'll do it before releasing 1.3, thanks! |
Fixes #15
This lets qtpy work with PySide2.
The tests completed on my end and I've manually tested using PySide2, both directly in Python and using Maya 2017 that ships with PySide2.
A few libraries aren't included in some builds of PySide2 by default, but like the other non-default Qt modules, I've left them in as is so that if someone builds PySide2 with them they'll work. Specifically QtMultimedia, QTest and QWebSettings were not available.
I figure it's better to have most of the functionality working than have all of it.