Repository navigation
Support CSP nonce on default login and passkey registration pages - #19869
Merged
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
ziqin
force-pushed
the
gh-19844
branch
2 times, most recently
from
October 14, 2026 19:32
8d2a59d to
7e09a72
Compare
Collaborator
ziqin
marked this pull request as ready for review
October 15, 2026 01:10
Contributor
Author
|
Hi, @jzheaux, Thank you for your help! Upon reflection, I removed Looking forward to your feedback! |
ziqin
force-pushed
the
gh-19844
branch
3 times, most recently
from
October 15, 2026 02:14
38b7418 to
4243a62
Compare
jzheaux
added
in: web
Closes spring-projectsgh-19844 Signed-off-by: Ziqin Wang <[email protected]>
Placing preventDefault before setupRegistration just in case setupRegistration fails. Signed-off-by: Josh Cummings <[email protected]>
Added coverage for missing nonce, HTML-escaped none, and a passkeys- disabled login page. Signed-off-by: Josh Cummings <[email protected]>
Collaborator
|
Thanks, @ziqin! This is now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements gh-19844.
TODOs: