Minor docs fix#15043
Merged
marcusdacoregio merged 1 commit intospring-projects:mainfrom May 15, 2024
vvaadd:apidoc-fix
Merged
Conversation
|
@vvaadd Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@vvaadd Thank you for signing the Contributor License Agreement! |
marcusdacoregio
suggested changes
May 13, 2024
Contributor
marcusdacoregio
left a comment
marcusdacoregio
left a comment
There was a problem hiding this comment.
Hi @vvaadd, thanks for the PR.
I've left some feedback inline.
| // ... | ||
| .exceptionHandling(e -> e.authenticationEntryPoint(authenticationEntryPoint())) | ||
| .addFilterBefore(digestFilter()); | ||
| .addFilterAfter(digestAuthenticationFilter(), ExceptionTranslationFilter.class); |
Contributor
There was a problem hiding this comment.
This method should be .addFilter(digestAuthenticationFilter()) since the DigestAuthenticationFilter has an entry in FilterOrderRegistration.
marcusdacoregio
removed
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
marcusdacoregio
removed
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
marcusdacoregio
added
in: docs
marcusdacoregio
approved these changes
May 15, 2024
Contributor
|
Thanks @vvaadd, this is now merged into |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed method names and arguments in reference docs