Add getters to OAuth2AuthorizedClientId#13648
Closed
ch4mpy wants to merge 3 commits intospring-projects:mainfrom
ch4mpy:authorized-client-id-getters
Closed
Add getters to OAuth2AuthorizedClientId#13648ch4mpy wants to merge 3 commits intospring-projects:mainfrom ch4mpy:authorized-client-id-getters
OAuth2AuthorizedClientId#13648ch4mpy wants to merge 3 commits intospring-projects:mainfrom
ch4mpy:authorized-client-id-getters
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
willns1
approved these changes
Sep 23, 2023
jzheaux
requested changes
Dec 20, 2023
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @ch4mpy. WIll you do me a couple of favors here, please?
- Update the copyright year
- Add JavaDoc. I realize that getter JavaDoc is sometimes a little cookie cutter; in this case it at least gives a place for a
@sinceattribute.
Contributor
Author
|
@jzheaux finally done |
Expose getters for principalName and clientRegistrationId which compose an OAuth2AuthorizedClientId
sjohnr
added
type: enhancement
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
OAuth2AuthorizedClientIdis enough to compare IDs, but I have a use case where I retrieve some if this IDs and need to access the registration ID, which is not possible right now.