Fix IP address parse error message in IpAddressMatcher#parseAddress()#11713
Merged
jzheaux merged 1 commit intospring-projects:mainfrom Aug 18, 2022
Merged
Fix IP address parse error message in IpAddressMatcher#parseAddress()#11713jzheaux merged 1 commit intospring-projects:mainfrom
jzheaux merged 1 commit intospring-projects:mainfrom
Conversation
There is no whitespace between error message and IP address value `IpAddressMatcher#parseAddress()` If IP value is wrong, then error text looks like `Failed to parse addressi.am.ip`. There should be some separator between those two text tokens. Also wrapped the address value with single quotes. Will this add any confusion for the caller? Or colon and `"Failed to parse address: $value` looks better?
|
@cyb3r4nt Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@cyb3r4nt Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: web
Contributor
|
Thanks, @cyb3r4nt! This is now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no whitespace between error message and IP address value
IpAddressMatcher#parseAddress()If IP value is wrong, then error text looks like
Failed to parse addressi.am.ip.There should be some separator between those two text tokens.
Also wrapped the address value with single quotes.
Will this add any confusion for the caller?
Or colon and
"Failed to parse address: $valuelooks better?