GH-2184: Don't Log KafkaBackoffException

garyrussell · artembilan · commit e5d23340512a · 2022-09-06T15:39:34.000-04:00
Resolves #2184 `KafkaBackOffException`s are incorrectly logged at ERROR level during retries when using the no-seek error handling mode. They are not logged in the seek mode; see 448871a **cherry-pick to 2.9.x**
diff --git a/spring-kafka/src/main/java/org/springframework/kafka/listener/DefaultErrorHandler.java b/spring-kafka/src/main/java/org/springframework/kafka/listener/DefaultErrorHandler.java
@@ -157,7 +157,12 @@ public boolean handleOne(Exception thrownException, ConsumerRecord<?, ?> record,
 			return getFailureTracker().recovered(record, thrownException, container, consumer);
 		}
 		catch (Exception ex) {
-			logger.error(ex, "Failed to handle " + KafkaUtils.format(record) + " with " + thrownException);
+			if (SeekUtils.isBackoffException(thrownException)) {
+				this.logger.debug(ex, "Failed to handle " + KafkaUtils.format(record) + " with " + thrownException);
+			}
+			else {
+				this.logger.error(ex, "Failed to handle " + KafkaUtils.format(record) + " with " + thrownException);
+			}
 			return false;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,12 @@ public boolean handleOne(Exception thrownException, ConsumerRecord<?, ?> record,`
`157`	`157`	`return getFailureTracker().recovered(record, thrownException, container, consumer);`
`158`	`158`	`}`
`159`	`159`	`catch (Exception ex) {`
`160`		`- logger.error(ex, "Failed to handle " + KafkaUtils.format(record) + " with " + thrownException);`
	`160`	`+ if (SeekUtils.isBackoffException(thrownException)) {`
	`161`	`+ this.logger.debug(ex, "Failed to handle " + KafkaUtils.format(record) + " with " + thrownException);`
	`162`	`+ }`
	`163`	`+ else {`
	`164`	`+ this.logger.error(ex, "Failed to handle " + KafkaUtils.format(record) + " with " + thrownException);`
	`165`	`+ }`
`161`	`166`	`return false;`
`162`	`167`	`}`
`163`	`168`	`}`