remove false comment about try-with-resources statement in StompSubProtocolHandler#35053
Closed
Pankraz76 wants to merge 3 commits intospring-projects:mainfrom
Closed
remove false comment about try-with-resources statement in StompSubProtocolHandler#35053Pankraz76 wants to merge 3 commits intospring-projects:mainfrom
try-with-resources statement in StompSubProtocolHandler#35053Pankraz76 wants to merge 3 commits intospring-projects:mainfrom
Conversation
added 2 commits
June 13, 2025 23:08
spring-projects-issues
added
the
status: waiting-for-triage
…otocolHandler Signed-off-by: Vincent Potucek <[email protected]>
Pankraz76
force-pushed
the
fix-StompSubProtocolHandler
branch
from
b0f0f9a to
547a0dc
Compare
Pankraz76
commented
Jun 14, 2025
| @@ -399,8 +399,6 @@ private void sendErrorMessage(WebSocketSession session, Throwable error) { | |||
| headerAccessor.setMessage(error.getMessage()); | |||
|
|
|||
| byte[] bytes = this.stompEncoder.encode(headerAccessor.getMessageHeaders(), EMPTY_PAYLOAD); | |||
Author
There was a problem hiding this comment.
primitive data type is not implementing interface autocloseable, seems impossible to use try-with-resources, right?.
not possible in L:413 ether, so idk if we still need this comment, as misleading.
Member
|
I don't understand the goal of this PR. The |
bclozel
added
status: declined
Author
|
can we merge test then at least to improve cover? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.