Skip to content

Comments

Support Optional for query parameters in UriBuilder and UriComponentsBuilder#25951

Closed
robinroos wants to merge 2 commits intospring-projects:masterfrom
robinroos:uribuilder-optionalqueryparam
Closed

Support Optional for query parameters in UriBuilder and UriComponentsBuilder#25951
robinroos wants to merge 2 commits intospring-projects:masterfrom
robinroos:uribuilder-optionalqueryparam

Conversation

@robinroos
Copy link
Contributor

Add a method optionalQueryParam(String, Optional) to the UriBuilder interface.

The implementation adds the query parameter contained by the optional to the URL. If the optional is empty then no action is taken; specifically the query parameter name is not added to the URL.

This PR replaces #25925 and #25950.

@robinroos robinroos changed the title Add a method for passing a queryParam which is an Optional UriBuilder - Add a method for passing a queryParam which is an Optional Oct 21, 2020
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 21, 2020
@rstoyanchev rstoyanchev self-assigned this Oct 21, 2020
@rstoyanchev rstoyanchev added this to the 5.3 GA milestone Oct 21, 2020
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 21, 2020
@robinroos robinroos requested a review from rstoyanchev October 21, 2020 18:19
rstoyanchev pushed a commit that referenced this pull request Oct 23, 2020
rstoyanchev added a commit that referenced this pull request Oct 23, 2020
@rstoyanchev rstoyanchev changed the title UriBuilder - Add a method for passing a queryParam which is an Optional Support Optional for query parameters in UriBuilder and UriComponentsBuilder Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants