Use lowercase property names in SpEL examples#25538
Closed
quaff wants to merge 1 commit intospring-projects:masterfrom
Closed
Use lowercase property names in SpEL examples#25538quaff wants to merge 1 commit intospring-projects:masterfrom
quaff wants to merge 1 commit intospring-projects:masterfrom
Conversation
According to java code conventions
Member
|
For the record, the proposed changes are to SpEL "property names", not variable names. As stated in the same chapter:
Thus, It's ultimately a matter of taste. Some people prefer to follow Java conventions. Others prefer capitalized property names in expressions for improved readability. In any case, I do think it would be beneficial to focus on Java coding conventions in the examples, with a In light of that, I'll probably merge this PR as-is and add such a note. |
sbrannen
added a commit
that referenced
this pull request
Oct 27, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to java code conventions