SPR-16604 - Prevent response body from being read at DefaultResponseErrorHandler.hasError() on unknown HTTP status code#1742
Closed
denysivano wants to merge 2 commits intospring-projects:4.3.xfrom
Closed
Conversation
When response contains unknown HTTP status code, do not read and waste response body. Issue: SPR-16604
|
@denysivano Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@denysivano Thank you for signing the Contributor License Agreement! |
denysivano
changed the title
Contributor
|
I've resolved this through direct enum value comparisons in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When response contains HTTP status code not defined in
HttpStatusenum,DefaultResponseErrorHandler.hasError(ClientHttpResponse response)callsgetHttpStatusCode(ClientHttpResponse response)which reads response body and throwsUnknownHttpStatusCodeException. In this casefalsevalue will be returned (which means response doesn't have error) andResponseExtractor.extract()inRestTemplateis called with response which body has been already read.Issue: SPR-16604