Skip to content

DefaultHandshakeHandler should not log client faults on error level #35930

@michaldo

Description

@michaldo

DefaultHandshakeHandler logs client errors on error level, for example

level: error
logger: DefaultHandshakeHandler 
message: Handshake failed due to invalid Upgrade header: null

It is wrong. Correct application behavior - reject malformed handshake - is reported as an error.
I monitor application error in log to detect wrong behavior and fix them.
If level error contains both wrong behavior and correct behavior, levelling has no sense at all.

Metadata

Metadata

Assignees

Labels

in: webIssues in web modules (web, webmvc, webflux, websocket)status: backportedAn issue that has been backported to maintenance branchestype: enhancementA general enhancement

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions