Skip to content

Introduced pessimistic locks for derived queries.#1158

Closed
DiegoKrupitza wants to merge 2 commits intospring-projects:mainfrom
DiegoKrupitza:feat/1041_query_lock_modes
Closed

Introduced pessimistic locks for derived queries.#1158
DiegoKrupitza wants to merge 2 commits intospring-projects:mainfrom
DiegoKrupitza:feat/1041_query_lock_modes

Conversation

@DiegoKrupitza
Copy link
Copy Markdown
Contributor

@DiegoKrupitza DiegoKrupitza commented Feb 4, 2022 •
edited by schauder
Loading

Methods which use the derive query functionality now can be annotated with @Lock to used a given LockMode. Right now there are two different modes PESSIMISTIC_READ and PESSIMISTIC_WRITE. Based on the dialect the right select is generated. For example for HSQLDB Select ... FOR UPDATE.

Related tickets #1041

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@DiegoKrupitza
Introduced pessimistic locks for derived queries.
9b4888b 
Methods which use the derive query functionality now can be annotated with `@Lock` to used a given `LockMode`. Right now there are two different modes `PESSIMISTIC_READ` and `PESSIMISTIC_WRITE`. Based on the dialect the right select is generated. For example for HSQLDB `Select ... FOR UPDATE`.

Related tickets spring-projects#1041
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 4, 2022
schauder pushed a commit that referenced this pull request Feb 9, 2022
@DiegoKrupitza @schauder
Introduced pessimistic locks for derived queries.
e68c355 
Methods which use the derive query functionality now can be annotated with `@Lock` to used a given `LockMode`. Right now there are two different modes `PESSIMISTIC_READ` and `PESSIMISTIC_WRITE`. Based on the dialect the right select is generated. For example for HSQLDB `Select ... FOR UPDATE`.

See #1041
Original pull request #1158
schauder added a commit that referenced this pull request Feb 9, 2022
@schauder
Polishing.
cd3d0b1 
Refactored the unit tests to include a negative case and to separate the different scenarios tested.

Removed the default LockMode from the Lock annotation.
I have the feeling that most users will assume an exclusive Lock when none is specified, but also don't want to request stronger locks than required.

Original pull request #1158
See #1041
@schauder
Copy link
Copy Markdown
Contributor

schauder commented Feb 9, 2022

Thanks for the PR that is polished and merged.

It does not solve #1041 since that one asked for the same thing, but for Spring Data R2DBC.
If you happen to be interested in tackling that as well, it would be highly appreciated.

@schauder schauder closed this Feb 9, 2022
@DiegoKrupitza
Copy link
Copy Markdown
Contributor Author

DiegoKrupitza commented Feb 9, 2022 •
edited
Loading

Thanks for the PR that is polished and merged.

It does not solve #1041 since that one asked for the same thing, but for Spring Data R2DBC.

Oh ok I don't know why I thought that 😅 . I am quite confused why is this issue then in the spring-data-jpa and not Spring Data R2DBC?

If you happen to be interested in tackling that as well, it would be highly appreciated.

If I find time for it I will take a closer look at it, but my R2DBC knowledge is quite limited...

@schauder

@schauder
Copy link
Copy Markdown
Contributor

schauder commented Feb 9, 2022

I am quite confused why is this issue then in the spring-data-jpa and not Spring Data R2DBC?

Well it's in spring-data-jdbc not spring-data-jpa 😂

Since both modules spring-data-jdbc and spring-data-r2dbc rely on spring-data-relational which is an artifact build from the spring-data-jdbc repository, it gets easy to get confused.

In the not to far future spring-data-jdbc and spring-data-r2dbc will get moved into one repository.
I'm not sure though if this will be helpful on the confusion front.

@DiegoKrupitza
Copy link
Copy Markdown
Contributor Author

DiegoKrupitza commented Feb 9, 2022

Well it's in spring-data-jdbc not spring-data-jpa 😂

Yeah I wrote spring-data-jpa by mistake 😂

In the not to far future spring-data-jdbc and spring-data-r2dbc will get moved into one repository. I'm not sure though if this will be helpful on the confusion front.

I think this won't make it better 😅 because when I hear "r2dbc" I instantly think about "reactive" and when I hear "jdbc" the last thing that comes to my mind is "reactive" 😅 , but maybe with clear documentation this should not be a problem

@schauder
Copy link
Copy Markdown
Contributor

schauder commented Feb 9, 2022

when I hear "r2dbc" I instantly think about "reactive" and when I hear "jdbc" the last thing that comes to my mind is "reactive"

And that is absolutely correct. But both use SQL to access relational databases, so they already have a lot in common and in the future will share even more code.

schauder pushed a commit that referenced this pull request Feb 15, 2022
@DiegoKrupitza @schauder
Introduced pessimistic locks for derived queries.
11a2364 
Methods which use the derive query functionality now can be annotated with `@Lock` to used a given `LockMode`. Right now there are two different modes `PESSIMISTIC_READ` and `PESSIMISTIC_WRITE`. Based on the dialect the right select is generated. For example for HSQLDB `Select ... FOR UPDATE`.

See #1041
Original pull request #1158
schauder added a commit that referenced this pull request Feb 15, 2022
@schauder
Polishing.
351ed47 
Refactored the unit tests to include a negative case and to separate the different scenarios tested.

Removed the default LockMode from the Lock annotation.
I have the feeling that most users will assume an exclusive Lock when none is specified, but also don't want to request stronger locks than required.

Original pull request #1158
See #1041
@DiegoKrupitza
Copy link
Copy Markdown
Contributor Author

DiegoKrupitza commented Feb 15, 2022 •
edited
Loading

It does not solve #1041 since that one asked for the same thing, but for Spring Data R2DBC.
@schauder

This should now be implemented with spring-projects/spring-data-r2dbc#720

schauder added a commit that referenced this pull request Feb 22, 2022
@schauder
Move Lock to relational module.
c8eafe7 
This allows both Spring Data R2DBC and Spring Data JDBC to use the same annotation.

See /issues/1041, spring-projects/spring-data-r2dbc/pull/720, /pull/1158
schauder added a commit that referenced this pull request Feb 22, 2022
@schauder
Move Lock to relational module.
4edb398 
This allows both Spring Data R2DBC and Spring Data JDBC to use the same annotation.

See /issues/1041, spring-projects/spring-data-r2dbc/pull/720, /pull/1158
schauder pushed a commit that referenced this pull request Feb 22, 2022
@DiegoKrupitza @schauder
Introduced pessimistic locks for derived queries.
910c340 
Methods which use the derive query functionality now can be annotated with `@Lock` to used a given `LockMode`. Right now there are two different modes `PESSIMISTIC_READ` and `PESSIMISTIC_WRITE`. Based on the dialect the right select is generated. For example for H2 `Select ... FOR UPDATE`.

Closes #1041
See #643,
Original pull request /pull/1158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DiegoKrupitza @schauder @spring-projects-issues