DATAREDIS-698 - Add support for HSTRLEN. #283
Closed
christophstrobl wants to merge 3 commits intomasterfrom
Closed
DATAREDIS-698 - Add support for HSTRLEN. #283christophstrobl wants to merge 3 commits intomasterfrom
christophstrobl wants to merge 3 commits intomasterfrom
Conversation
We now support HSTRLEN command throughout RedisHashCommand for Lettuce and Jedis in both an imperative and reactive manner. However, Jedis not natively supporting HSTRLEN via its API we’ve come up with some more reflective invocation allowing to execute commands currently not known by Jedis. We also added this behavior to the cluster implementation which as of now also supports RedisClusterConnection#execute.
Eagerly initialize known commands. Preallocate Jedis response builder. Replace list concatenation with array copy. Reject null arguments in execute() Remove inversion through collections with direct byte array creation. Reorder signatures, visibility modifiers, Javadoc.
mp911de
force-pushed
the
issue/DATAREDIS-698
branch
from
ba3ff9f to
be3d937
Compare
mp911de
pushed a commit
that referenced
this pull request
Oct 10, 2017
We now support HSTRLEN command throug RedisHashCommands for Lettuce and Jedis in both an imperative and reactive manner. However, Jedis not natively supporting HSTRLEN via its API we’ve come up with some more reflective invocation allowing to execute commands currently not known by Jedis. We also added this behavior to the cluster implementation which as of now also supports RedisClusterConnection#execute. Original pull request: #283.
mp911de
added a commit
that referenced
this pull request
Oct 10, 2017
Eagerly initialize known commands. Preallocate Jedis response builder. Replace list concatenation with array copy. Reject null arguments in execute(). Remove inversion through collections with direct byte array creation. Reorder arguments in signatures, visibility modifiers, Javadoc. Original pull request: #283.
Member
|
That's merged now. |
pavel-hp
reviewed
Jun 18, 2019
| Assert.notNull(args, "Args must not be null!"); | ||
|
|
||
| return clusterCommandExecutor | ||
| .executeCommandOnArbitraryNode((JedisClusterCommandCallback<Object>) client -> JedisClientUtils.execute(command, |
Contributor
There was a problem hiding this comment.
Hello! @christophstrobl
I have a question. Why you have chosen executeCommandOnArbitraryNode?
What If someone decided to use this API to run another command like:
connection.execute("FLUSHDB", "ASYNC".getBytes("UTF-8"));
Don't you think that in this case execution behaviour would be different?
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now support
HSTRLENcommand throughoutRedisHashCommandfor Lettuce and Jedis in both an imperative and reactive (Lettuce only) manner.However as Jedis does not natively support
HSTRLENvia its API we’ve come up with some more reflective invocation allowing to execute commands currently not known by Jedis. We also added this behavior to the cluster implementation which as of now also supportsRedisClusterConnection#execute.