Move id check to after conversion event publication in reactive flow#5156
Closed
christophstrobl wants to merge 2 commits intomainfrom
Closed
Move id check to after conversion event publication in reactive flow#5156christophstrobl wants to merge 2 commits intomainfrom
christophstrobl wants to merge 2 commits intomainfrom
Conversation
This commit makes sure to invoke the id check after publishing the before convert event to prevent failures where the event listener is responsible for setting the id.
mp911de
changed the title
mp911de
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #5155