Provide DocumentReferenceSource to document reference lookup for use of properties in constructor creation#4486
Closed
Provide DocumentReferenceSource to document reference lookup for use of properties in constructor creation#4486
DocumentReferenceSource to document reference lookup for use of properties in constructor creation#4486Conversation
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: bug
mp911de
changed the title
DocumentReferenceSource to document reference lookup for use of properties in constructor creation
Member
|
LGTM |
Member
|
I updated the ticket title. One-to-many didn't fit necessarily as we can have single-valued references as well. |
This commit enables document reference lookup to use `DocumentReferenceSource` to properly instantiate an entity containig a @DocumentReference `#self` property. Closes #4484
Add myself to list of authors. Original Pull Request: #4486
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables a source entity with a one-to-many @DocumentReference lookup property to be instantiated properly when the referenced entity - which contains the linking value - is used as a constructor argument.