Support custom countSpec in SimpleJpaRepository.findAll#3727
Closed
JoshuaChen wants to merge 4 commits intospring-projects:mainfrom
Closed
Support custom countSpec in SimpleJpaRepository.findAll#3727JoshuaChen wants to merge 4 commits intospring-projects:mainfrom
JoshuaChen wants to merge 4 commits intospring-projects:mainfrom
Conversation
|
@JoshuaChen Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@JoshuaChen Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: enhancement
Member
|
Thanks for your suggestion. We're going to include it. However, next time, please squash your commits into one and make sure to include tests. |
mp911de
modified the milestones:
4.0 M1 (2025.1.0),
3.4.3 (2024.1.3),
3.5 M1 (2025.0.0)
mp911de
added a commit
that referenced
this pull request
Jan 23, 2025
Add SpecificationFluentQuery to include specification-related overloads. Also, add slice(…) terminal method to obtain a slice only without running a count query. See #3727
mp911de
pushed a commit
that referenced
this pull request
Jan 23, 2025
mp911de
added a commit
that referenced
this pull request
Jan 23, 2025
Add SpecificationFluentQuery to include specification-related overloads. Also, add slice(…) terminal method to obtain a slice only without running a count query. See #3727
Member
|
Thank you for your contribution. That's merged and polished now. |
mp911de
pushed a commit
that referenced
this pull request
Mar 17, 2025
mp911de
added a commit
that referenced
this pull request
Mar 17, 2025
Add SpecificationFluentQuery to include specification-related overloads. Also, add slice(…) terminal method to obtain a slice only without running a count query. See #3727
mp911de
pushed a commit
that referenced
this pull request
Apr 14, 2025
mp911de
added a commit
that referenced
this pull request
Apr 14, 2025
Add SpecificationFluentQuery to include specification-related overloads. Also, add slice(…) terminal method to obtain a slice only without running a count query. See #3727
mp911de
pushed a commit
that referenced
this pull request
May 16, 2025
mp911de
added a commit
that referenced
this pull request
May 16, 2025
Add SpecificationFluentQuery to include specification-related overloads. Also, add slice(…) terminal method to obtain a slice only without running a count query. See #3727
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some performance optimization scenarios, a custom count spec is needed to improve query performance.