Fix Hql-Queries using CEILING and LN.#3711
Closed
coderesting wants to merge 2 commits intospring-projects:mainfrom
Closed
Fix Hql-Queries using CEILING and LN.#3711coderesting wants to merge 2 commits intospring-projects:mainfrom
coderesting wants to merge 2 commits intospring-projects:mainfrom
Conversation
|
@coderesting Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@coderesting Thank you for signing the Contributor License Agreement! |
mp911de
added
type: bug
Member
|
Thanks a lot. We're generally limited towards function names that we declare while Hibernate accepts unknown function names. That requires a slightly different approach to allow these. I'll take care of this during the merge. |
mp911de
pushed a commit
that referenced
this pull request
Dec 11, 2024
mp911de
added a commit
that referenced
this pull request
Dec 11, 2024
Align HQL parsing with Hibernate to accept generic function names. Also, align literals, add missing expression grammar for ID, NATURALID, VERSION, TYPE, FK and remove parser rules interfering with undesired parsing results. Add missing literals. See #3711
mp911de
added a commit
that referenced
this pull request
Dec 11, 2024
Align HQL parsing with Hibernate to accept generic function names. Also, align literals, add missing expression grammar for ID, NATURALID, VERSION, TYPE, FK and remove parser rules interfering with undesired parsing results. Add missing literals. See #3711
Member
|
Thank you for your contribution. That's merged, polished, and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hibernate functions ceiling and ln are currently breaking the spring-data Query validation.
Problem: CEILING and LN were defined as reserved identifiers in the hql grammar file but never used.
Solution: This Pull Request adds CEILING and LN to the List of reserved words for use as a function name or identifier.