Optimize entity deletion in SimpleJpaRepository#3564
Closed
Seol-JY wants to merge 2 commits intospring-projects:mainfrom
Closed
Optimize entity deletion in SimpleJpaRepository#3564Seol-JY wants to merge 2 commits intospring-projects:mainfrom
Seol-JY wants to merge 2 commits intospring-projects:mainfrom
Conversation
This change improves the performance of the delete method by first checking if the entity is already managed by the EntityManager. If so, it removes the entity directly without additional database queries. This optimization can reduce unnecessary database lookups in certain scenarios.
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
mp911de
added
type: enhancement
mp911de
added a commit
that referenced
this pull request
Aug 13, 2024
Defer user-class lookup. See #3564
mp911de
pushed a commit
that referenced
this pull request
Aug 13, 2024
This change improves the performance of the delete method by first checking if the entity is already managed by the EntityManager. If so, it removes the entity directly without additional database queries. This optimization can reduce unnecessary database lookups in certain scenarios. Closes #3564
mp911de
added a commit
that referenced
this pull request
Aug 13, 2024
Defer user-class lookup. See #3564
Member
|
Thank you for your contribution. That's merged, polished, and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the
deletemethod inSimpleJpaRepositoryto improve performance in certain scenarios. The main change is to first check if the entity is already managed by the EntityManager.entityManager.contains(entity)at the beginning of the methodThe goal of this change is to reduce unnecessary database lookups when deleting managed entities, potentially improving performance in high-throughput scenarios.The goal of this change is to optimize the deletion process for entities that are already managed by the EntityManager (present in the first-level cache). This can potentially improve performance in scenarios where entities are likely to be in the cache before deletion, such as when using the
deleteByIdmethod after recent read or write operations.Please point out any potential risks or edge cases where this change might lead to unexpected behavior.