Add support for index aliases.#2905
Conversation
sothawo
left a comment
There was a problem hiding this comment.
Sorry it took me a while to get to this.
I don't think that AliasCoordinates should be added to IndexCoordinates. IndexCoordinates is used throughout the library wherever an index name or names are passed. Adding the alias information might cause the user to think he might add some alias info to other functions where this is definitely not. I think that the alias information should be passed to the IndicesTemplate.create() and ReactiveIndicesTemplate.create() functions like it's done with mapping and settings. This is something only relevant during index creation.
Also I am not sure about reusing the @Query annotation. In Spring Data context this normally only exists on repository methods. The documentation for @Query says that the query can contain parameters like ?0, this of course is not valis in the index creation process. I'd rather suggest to creat a new @Filter annotation that is only used in the index creation context.
sothawo
left a comment
There was a problem hiding this comment.
Sorry, have been pretty busy (and sick in between), just a first remark, had no time to look further
Signed-off-by: Youssef Aouichaoui <[email protected]>
Co-authored-by: Peter-Josef Meisch <[email protected]>
Signed-off-by: Youssef Aouichaoui <[email protected]>
102c502 to
cf02680
Compare
sothawo
left a comment
There was a problem hiding this comment.
nice work, thank you.
Some minor things. And the reactive integration test is missing
Signed-off-by: Youssef Aouichaoui <[email protected]> Co-authored-by: Peter-Josef Meisch <[email protected]>
Signed-off-by: Youssef Aouichaoui <[email protected]>
Closes #2599